Skip to content

prototype(progress-bar): create prototype progress bar based on MDC web #17224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 28, 2019

Implements the Angular Material progress bar on top of MDC web. The public API and behavior should be identical, aside from slight differences in the animation timings and easing curves.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 28, 2019
@crisbeto crisbeto force-pushed the mdc-progress-bar branch 2 times, most recently from 537ca65 to 4474abb Compare September 28, 2019 09:56
@crisbeto crisbeto marked this pull request as ready for review September 28, 2019 10:12
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Sep 28, 2019
@crisbeto
Copy link
Member Author

crisbeto commented Oct 1, 2019

I've addressed the feedback @jelbourn @mmalerba. Also I've reverted the hacky workaround for the MDC theme breaking the unit test runs.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 2, 2019
@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label Oct 2, 2019
Implements the Angular Material progress bar on top of MDC web. The public API and behavior should be identical, aside from slight differences in the animation timings and easing curves.
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 2, 2019
@mmalerba mmalerba merged commit fc6cb10 into angular:master Oct 2, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants