build: tests should not fail if stylesheets contain quotes #17251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently our workaround that allows us to use stylesheets in the karma web test suites is not very robust and fails if stylesheets use single quotes. e.g. `@material/linear-progress`: https://unpkg.com/browse/@material/[email protected]/_mixins.scss In order to fix this, we use double-quotes and always escape double-quotes in the CSS content. This is still a bit hacky, but so is the overall workaround to make it work.
googlebot
added
the
cla: yes
devversion
added
pr: merge safe
target: patch
mmalerba
pushed a commit
that referenced
this pull request
Oct 8, 2019
Currently our workaround that allows us to use stylesheets in the karma web test suites is not very robust and fails if stylesheets use single quotes. e.g. `@material/linear-progress`: https://unpkg.com/browse/@material/[email protected]/_mixins.scss In order to fix this, we use double-quotes and always escape double-quotes in the CSS content. This is still a bit hacky, but so is the overall workaround to make it work. (cherry picked from commit f30d26f)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our workaround that allows us to use stylesheets
in the karma web test suites is not very robust and fails if
stylesheets use single quotes. e.g.
@material/linear-progress:https://unpkg.com/browse/@material/[email protected]/_mixins.scss
In order to fix this, we use double-quotes and always escape double-quotes
in the CSS content. This is still a bit hacky, but so is the overall workaround to
make it work.