Skip to content

build: fix write permissions for bazel npm_package output #17273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

@devversion devversion commented Oct 2, 2019

We need to update permissions for the copied "npm_package". Bazel makes these files readonly
in the "bazel-out", but for publishing, they should be writable. Also it's necessary in order to be able to update the "package.json" version

@devversion devversion requested a review from a team as a code owner October 2, 2019 16:32
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 2, 2019
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Oct 2, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 2, 2019
@mmalerba mmalerba merged commit 3b0f604 into angular:master Oct 2, 2019
@devversion devversion deleted the build/fix-permissions-bazel-docs-content branch October 2, 2019 16:58
mmalerba pushed a commit that referenced this pull request Oct 8, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants