Skip to content

chore: bump version to 9.0.0-next.0 w/ changelog #17288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Oct 3, 2019

No description provided.

@jelbourn jelbourn added pr: merge safe target: major This PR is targeted for the next major release labels Oct 3, 2019
@jelbourn jelbourn requested a review from a team as a code owner October 3, 2019 21:28
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 3, 2019
CHANGELOG.md Outdated

| | |
| ---------- | --------------------- |
| bug fix | **drag-drop:** dragging styles not reset once dragging is… ([#17150](https://github.com/angular/components/issues/17150)) ([e62e6bd](https://github.com/angular/components/commit/e62e6bd)), closes [#17139](https://github.com/angular/components/issues/17139) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include last part: "dragging styles not reset once dragging is completed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. not sure why it is cut off like that. Might be good always including the full commit title?

CHANGELOG.md Outdated
| ---------- | --------------------- |
| bug fix | **a11y:** focus monitor not identifying touch focus inside shadow root ([#17167](https://github.com/angular/components/issues/17167)) ([3673f3d](https://github.com/angular/components/commit/3673f3d)) |
| bug fix | **datepicker:** year not formatted in multi-year view button ([#17202](https://github.com/angular/components/issues/17202)) ([ae28fce](https://github.com/angular/components/commit/ae28fce)), closes [#17187](https://github.com/angular/components/issues/17187) |
| bug fix | **overlay:** error when trying to add/remove empty string cla… ([#14919](https://github.com/angular/components/issues/14919)) ([5509c23](https://github.com/angular/components/commit/5509c23)) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"error when trying to add/remove empty string class"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devversion is it the changelog script that's truncating commit messages?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked the same question above. looks like it. I'll have a look at this tomorrow.

Copy link
Member

@devversion devversion Oct 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it looks like it just comes from the commit messages which are too long. I'll have a look if we can somehow compute the full commit title for the changelog.

Copy link
Member

@devversion devversion Oct 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jelbourn Just checked back on this. Looks like it's just an issue with the individual commits. This seems to be because the Github UI truncates the title, and now if you use squash & merge it uses the PR title as commit title? (which contains the ellipsis)

@jelbourn jelbourn force-pushed the release-stage/9.0.0-next.0 branch from 39d330a to 3e499d3 Compare October 3, 2019 22:18
@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 3, 2019
@jelbourn jelbourn merged commit 569c149 into angular:master Oct 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants