Skip to content

feat(drag-drop): allow drag start delay to be configured based on event type #17301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 5, 2019

Allows the consumer to configure the drag start delay based on whether it's a touch event or mouse event.

Fixes #17260.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release labels Oct 5, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 5, 2019
…nt type

Allows the consumer to configure the drag start delay based on whether it's a touch event or mouse event.

Fixes angular#17260.
@crisbeto crisbeto force-pushed the 17260/drag-drop-delay-by-event branch from 64f8a8d to 4c4e708 Compare October 5, 2019 15:19
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 7, 2019
@crisbeto crisbeto added this to the 9.0.0 milestone Oct 7, 2019
@mmalerba mmalerba merged commit 43c7a7d into angular:master Oct 14, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to use dragStartDelay only for touch events
4 participants