build: ensure to never output files next to sources #17362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a few tsconfig files which are not used by Bazel and therefore can be run manually/or by IDEs. In any case, for these TS projects we never want to output the JS files next to the sources. This would cause the files to show up in the Git repository tree. The scenario that someone runs this manually, or that IDEs build the project somehow is rare, but it's generally good setting the output directory for these tsconfig files. Note: we cannot do this for the Bazel tsconfig files as this would result in warnings from `@bazel/typescript`
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few tsconfig files which are not used by Bazel and therefore
can be run manually/or by IDEs.
In any case, for these TS projects we never want to output the JS
files next to the sources. This would cause the files to show up
in the Git repository tree.
The scenario that someone runs this manually, or that IDEs build
the project somehow is rare, but it's generally good setting the
output directory for these tsconfig files.
Note: we cannot do this for the Bazel tsconfig files as this
would result in warnings from
@bazel/typescript