Skip to content

chore(saucelabs): interrupt if saucelabs tunnel does not start #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2016

Conversation

devversion
Copy link
Member

@devversion devversion commented Nov 5, 2016

  • Adds a timeout to the Saucelabs wait script (as same as in the browserstack tunnel)
  • Logs dots while waiting for the tunnel to be ready (same as in the saucelabs wait script)
  • No longer calls print-logs file (File does not exist and also browserstacktunnel-wrapper prints necessary output to the console)

Fixes

and Travis builds like this one, which can run about 2 hours

* Adds a timeout to the Saucelabs Wait script (as same as in the browserstack tunnel)
* Logs dots while waiting for the tunnel to be ready (same as in the saucelabs wait script)
* No longer calls `print-logs` file - File does not exist and also `browserstacktunnel-wrapper` prints necessary output to the console.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 5, 2016
@jelbourn
Copy link
Member

jelbourn commented Nov 8, 2016

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 8, 2016
@jelbourn jelbourn merged commit 9bb4809 into angular:master Nov 8, 2016
rolandjitsu pushed a commit to rolandjitsu/material2 that referenced this pull request Nov 10, 2016
@devversion devversion deleted the chore/saucelabs-tunnel-timeout branch November 12, 2016 12:09
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants