Skip to content

build: remove rollup windows postinstall workaround #17669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

We can remove the rollup windows postinstall workaround
since we updated to @angular/bazel#9.0.0-rc.1 which
includes a fix for this issue.

We can remove the rollup windows postinstall workaround
since we updated to `@angular/bazel#9.0.0-rc.1` which
includes a fix for this issue.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 11, 2019
@devversion devversion requested review from jelbourn and a team as code owners November 11, 2019 12:26
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 11, 2019
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 11, 2019
@mmalerba mmalerba merged commit e8ee641 into angular:master Nov 11, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants