Skip to content

docs(cdk/testing): add documentation for harness environment authors #17754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 22, 2019

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround pr: merge safe labels Nov 19, 2019
@mmalerba mmalerba added this to the 9.0.0 milestone Nov 19, 2019
@mmalerba mmalerba requested a review from jelbourn November 19, 2019 20:11
@mmalerba mmalerba requested a review from devversion as a code owner November 19, 2019 20:11
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 19, 2019
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Nov 19, 2019
@jelbourn
Copy link
Member

Here's my proposed edits: jelbourn@da6225e

@mmalerba mmalerba force-pushed the harness-env-docs branch 2 times, most recently from 5aa9acc to 27e8f23 Compare November 20, 2019 22:10
@mmalerba
Copy link
Contributor Author

Mostly fine with the edits, but I did add back the bit at the beginning describing what a "harness environment author" is. Earlier in these docs there's a paragraph that lays out the different classes of developer that someone might fall into (test author, harness author, harness environment author) and promises to explain more about each later

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 22, 2019
@jelbourn jelbourn merged commit ddb2960 into angular:master Nov 22, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants