Skip to content

build: rework package-builder script to node script #17758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

Reworks the package-builder script from a Bash script
to a NodeJS script. This makes it work better in all
platforms, and makes the script more maintainable.

Best example is how easy it can be integrated into the
release tool. Framework did the same recently.

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 20, 2019
@devversion devversion requested review from jelbourn and a team as code owners November 20, 2019 11:27
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 20, 2019
Reworks the package-builder script from a Bash script
to a NodeJS script. This makes it work better in all
platforms, and makes the script more maintainable.

Best example is how easy it can be integrated into the
release tool. Framework did the same recently.
@devversion devversion force-pushed the build/rework-package-builder-script-to-js branch from 17cd246 to 1a47fe1 Compare November 20, 2019 11:34
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Nov 20, 2019
@jelbourn jelbourn merged commit 5428e93 into angular:master Nov 20, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants