build: enable bazel node modules symlinking [resubmit w/ fixes] #17776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts the revert the reverts: 49527e5.
Apparently we accidentally skipped a few postinstall patches because we added the edit marker file for the first patch being applied to a file. This causes subsequent patches targeting the same file to be skipped accidentally
googlebot
added
the
cla: yes
devversion
added
pr: merge safe
target: patch
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmit with fixes for the release building failures.
The symlinking allowed us use caching for node_modules. This meant that we needed
to rework how we apply postinstall patches to:
To do this, we implemented something called "marker files" that can be used to
determine if a file has been patched or not. Unfortunately I didn't realize that we
have multiple individual patches for the same file, so the first patch edit created the
marker, and followed patches for the same file got skipped.