Skip to content

docs: rename cdk/testing overview doc name #17779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2019
Merged

docs: rename cdk/testing overview doc name #17779

merged 1 commit into from
Nov 22, 2019

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Nov 22, 2019 •
edited
Loading

@jelbourn jelbourn added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful docs This issue is related to documentation pr: merge safe labels Nov 22, 2019
@jelbourn jelbourn added this to the 9.0.0 milestone Nov 22, 2019
@jelbourn jelbourn requested a review from mmalerba November 22, 2019 00:10
@jelbourn jelbourn requested a review from devversion as a code owner November 22, 2019 00:10
@jelbourn jelbourn mentioned this pull request Nov 22, 2019
Merged
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 22, 2019
devversion
devversion approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the Bazel build file needs to be updated. Currently still has the old .md file as input.

@jelbourn jelbourn force-pushed the harness-docs-rename branch from e5cf0a1 to 075af64 Compare November 22, 2019 23:08
@jelbourn jelbourn merged commit 3766065 into angular:master Nov 22, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jelbourn @devversion @googlebot