build: migrate to new --define=angular_ivy_enabled flag #17792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
approved these changes
Nov 25, 2019
.bazelrc
Outdated
| @@ -40,9 +40,10 @@ build:release --workspace_status_command="node ./tools/bazel-stamp-vars.js" | |||
| ################################ | |||
| # View Engine / Ivy toggle # | |||
| ################################ | |||
| build --define=angular_ivy_enabled=True | |||
There was a problem hiding this comment.
We can avoid the duplication by using common --config=ivy
devversion
added
pr: lgtm
blocked
devversion
removed
the
blocked
josephperrott
force-pushed
the
new-ivy-define-flag
branch
2 times, most recently
from
2114a88 to
af557aa
Compare
Remove all usage of --define=compile=* within the repo, using --config=ivy and --config=view-engine instead. This matches the changes in the angular/angular repo and is clearer to developers what the flag is actually doing.
josephperrott
force-pushed
the
new-ivy-define-flag
branch
from
af557aa to
c62d237
Compare
josephperrott
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all usage of --define=compile=* within the repo, using --config=ivy and
--config=view-engine instead. This matches the changes in the angular/angular
repo and is clearer to developers what the flag is actually doing.