chore(dev-app) Add demo page for FocusTrap #17858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanessanschmitt
requested review from
jelbourn,
mmalerba and
a team
as code owners
googlebot
added
the
cla: yes
vanessanschmitt
force-pushed
the
focus-trap-demo
branch
from
7b57341 to
66da82a
Compare
jelbourn
reviewed
Dec 2, 2019
vanessanschmitt
force-pushed
the
focus-trap-demo
branch
from
66da82a to
ef171a5
Compare
jelbourn
approved these changes
Dec 3, 2019
jelbourn
added
pr: lgtm
target: patch
|
(also you can ignore that failing |
|
Also I just loaded the this locally and this is really good set of demos. I want to turn them into examples for our documentation. |
vanessanschmitt
force-pushed
the
focus-trap-demo
branch
from
ef171a5 to
6894a3c
Compare
Note that much of this demo page is known to not be working with the current focus trap implementation (ex. elements in the focus trap with tabindex > 0 send focus out of the trap, elements in iframes/shadow DOM get skipped when focus wraps, all focus traps can be escaped by clicking on the URL and then pressing tab). The demo page will be helpful for research into FocusTrap improvements (see angular#13054).
vanessanschmitt
force-pushed
the
focus-trap-demo
branch
from
6894a3c to
9f33618
Compare
|
Wow, thanks! Let me know if there's anything I can do to help with that. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that much of this demo page is known to not be working with the
current focus trap implementation (ex. elements in the focus trap with
tabindex > 0 send focus out of the trap, elements in iframes/shadow DOM
get skipped when focus wraps, all focus traps can be escaped by clicking
on the URL and then pressing tab). The demo page will be helpful for
research into FocusTrap improvements (see
#13054).