Skip to content

fix(material/datepicker): remove fixed width as not working on mobile #17866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

ajitsinghkaler
Copy link
Contributor

In date picker the events example is not responsive on mobile because it has fixed width now changed it to max-width

Datepicker   Angular Material (1)

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 3, 2019
@jelbourn jelbourn requested a review from mmalerba December 3, 2019 21:28
@mmalerba
Copy link
Contributor

mmalerba commented Dec 3, 2019

@ajitsinghkaler I would also be fine with just removing the width/max-width completely. I don't think it's really necessary.

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 3, 2019
@ngbot
Copy link

ngbot bot commented Dec 3, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: api_golden_checks" is failing
    pending missing required labels: target: *

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Dec 3, 2019
@mmalerba
Copy link
Contributor

mmalerba commented Dec 3, 2019

The API golden checks is just something that was broken at head for a little while, this PR is fine

In date picker the events example is not responsive on mobile.So, I removed it.
@ajitsinghkaler
Copy link
Contributor Author

@mmalerba I've made the change can you please look into the request now.

@ajitsinghkaler
Copy link
Contributor Author

@mmalerba now what do I have to do to get the checks right.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants