refactor: remove ts 3.7 compatibility type cast in ripple-renderer #17934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8fd9d7d added a compatibility type cast to the ripple renderer. To actually fix the assignment in a non-cast way that works for TS 3.6 and TS 3.7, we just assign the `backgroundColor` style property if actually needed.
devversion
added
the
target: patch
googlebot
added
the
cla: yes
devversion
changed the title
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8fd9d7d added a type cast to an assignment in the
RippleRendererin orderto make it compatible with TS 3.7.
To make the assignment compatible with TS 3.7 in a way that does not require a
type-cast, we just assign the
backgroundColorstyle property if actually needed.