fix(tabs): don't start auto-scroll when right clicking on buttons #18033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we use `mousedown` to figure out when to start auto-scrolling the tab header, but the event is also dispatched for right clicks. This can be weird, because accidental right clicks that open the system dropdown can start scrolling without being able to stop it easily. These changes make it so we only start for left button clicks.
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
Jan 22, 2020
…8033) Currently we use `mousedown` to figure out when to start auto-scrolling the tab header, but the event is also dispatched for right clicks. This can be weird, because accidental right clicks that open the system dropdown can start scrolling without being able to stop it easily. These changes make it so we only start for left button clicks. (cherry picked from commit bd62f98)
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
…gular#18033) Currently we use `mousedown` to figure out when to start auto-scrolling the tab header, but the event is also dispatched for right clicks. This can be weird, because accidental right clicks that open the system dropdown can start scrolling without being able to stop it easily. These changes make it so we only start for left button clicks.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use
mousedownto figure out when to start auto-scrolling the tab header, but the event is also dispatched for right clicks. This can be weird, because accidental right clicks that open the system dropdown can start scrolling without being able to stop it easily. These changes make it so we only start for left button clicks.