fix(material-experimental/mdc-chips): remove aria-hidden from focusable element #18054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
mdc-chip-remove-tabindex
branch
from
ae3ec67 to
9277e31
Compare
crisbeto
commented
Dec 27, 2019
crisbeto
force-pushed
the
mdc-chip-remove-tabindex
branch
from
9277e31 to
67e6c5d
Compare
…le element The MDC-based `MatChipRemove` extends the `MatChipTrailingIcon` which has `aria-hidden`, however the `MatChipRemove` is focusable which is invalid. These changes clear the `aria-hidden` from the remove icon.
crisbeto
force-pushed
the
mdc-chip-remove-tabindex
branch
from
67e6c5d to
79de9ef
Compare
crisbeto
changed the title
mmalerba
approved these changes
Dec 28, 2019
mmalerba
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MDC-based
MatChipRemoveextends theMatChipTrailingIconwhich hasaria-hidden, however theMatChipRemoveis focusable which is invalid. These changes clear thearia-hiddenfrom the remove icon.