build: focus trap demo not working on IE/Edge #18106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The focus trap demo throws an error in IE and Edge, because it uses a component with Shadom DOM encapsulation. Adding an `ngIf` around it will break its functionality, because of the way the focus traps are initialized inside `ngAfterViewInit`. These changes switch the demo to use the focus trap directive and make it so we can test the demo against IE and Edge.
crisbeto
added
P3
googlebot
added
the
cla: yes
devversion
approved these changes
Jan 6, 2020
| import {MatDialog} from '@angular/material/dialog'; | ||
| import {_supportsShadowDom} from '@angular/cdk/platform'; |
There was a problem hiding this comment.
Out of curiosity: did we ever consider just publishing this without underscore?
There was a problem hiding this comment.
I don't remember if we ever discussed making it public.
devversion
added
pr: lgtm
action: merge
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
The focus trap demo throws an error in IE and Edge, because it uses a component with Shadom DOM encapsulation. Adding an `ngIf` around it will break its functionality, because of the way the focus traps are initialized inside `ngAfterViewInit`. These changes switch the demo to use the focus trap directive and make it so we can test the demo against IE and Edge.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The focus trap demo throws an error in IE and Edge, because it uses a component with Shadom DOM encapsulation. Adding an
ngIfaround it will break its functionality, because of the way the focus traps are initialized insidengAfterViewInit. These changes switch the demo to use the focus trap directive and make it so we can test the demo against IE and Edge.