Skip to content

refactor: remove abstract directives injection workaround #18109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2020
Merged

refactor: remove abstract directives injection workaround #18109

merged 1 commit into from
Jan 8, 2020

Conversation

devversion
Copy link
Member

Previously we had to make sure that every constructor
parameter of abstract directive classes resolves to a
suitable DI token. This was caused by a bug that has been
solved in version 9. Hence we can remove the workaround.

@devversion devversion added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jan 6, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 6, 2020
@devversion
refactor: remove abstract directives injection workaround
0028443 
Previously we had to make sure that every constructor
parameter of abstract directive classes resolves to a
suitable DI token. This was caused by a bug that has been
solved in version 9. Hence we can remove the workaround.
@devversion devversion force-pushed the refactor/remove-injection-workaround-angular-9 branch from c2b4659 to 0028443 Compare January 6, 2020 12:43
crisbeto
crisbeto approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 6, 2020
@mmalerba mmalerba merged commit d1de6fa into angular:master Jan 8, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@devversion @yifange
refactor: remove abstract directives injection workaround (angular#18109
f6744b7 
)

Previously we had to make sure that every constructor
parameter of abstract directive classes resolves to a
suitable DI token. This was caused by a bug that has been
solved in version 9. Hence we can remove the workaround.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devversion @crisbeto @jelbourn @googlebot @mmalerba