Skip to content

build: bump to latest Angular version #18186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Conversation

crisbeto
Copy link
Member

Bumps all of the Angular dependencies to 9.0.0-rc.9.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release labels Jan 16, 2020
@crisbeto crisbeto requested review from jelbourn and a team as code owners January 16, 2020 06:51
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 16, 2020
@crisbeto crisbeto force-pushed the ng-9.0.0-rc.9 branch 2 times, most recently from 4ee449b to 6e61127 Compare January 16, 2020 09:38
Bumps all of the Angular dependencies to 9.0.0-rc.9.
@crisbeto
Copy link
Member Author

Bumping this to a P2, because I had to update to TS 3.7 to avoid a build error. As a result all the API goldens had to be re-created.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jan 16, 2020
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not adding merge ready since I don't know if we can already switch to TS 3.7 in terms of g3?

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is merge-safe so long as we don't change the source to use something that 3.6 doesn't support yet.

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker pr: merge safe labels Jan 16, 2020
@jelbourn jelbourn merged commit 6973145 into angular:master Jan 16, 2020
@mmalerba
Copy link
Contributor

Should we have bumped the ts version if we can't actually use 3.7 features yet? It sounds like asking for trouble down the line

@crisbeto
Copy link
Member Author

We had to do it in order to be able to bump the Angular version.

devversion pushed a commit to devversion/material2 that referenced this pull request Jan 27, 2020
Bumps all of the Angular dependencies to 9.0.0-rc.9.
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
Bumps all of the Angular dependencies to 9.0.0-rc.9.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants