-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: bump to latest Angular version #18186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4ee449b
to
6e61127
Compare
Bumps all of the Angular dependencies to 9.0.0-rc.9.
6e61127
to
6fe22ad
Compare
Bumping this to a P2, because I had to update to TS 3.7 to avoid a build error. As a result all the API goldens had to be re-created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm not adding merge ready since I don't know if we can already switch to TS 3.7 in terms of g3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is merge-safe so long as we don't change the source to use something that 3.6 doesn't support yet.
Should we have bumped the ts version if we can't actually use 3.7 features yet? It sounds like asking for trouble down the line |
We had to do it in order to be able to bump the Angular version. |
Bumps all of the Angular dependencies to 9.0.0-rc.9.
Bumps all of the Angular dependencies to 9.0.0-rc.9.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bumps all of the Angular dependencies to 9.0.0-rc.9.