Skip to content

build: print error if prerender test fails #18190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2020
Merged

build: print error if prerender test fails #18190

merged 1 commit into from
Jan 16, 2020

Conversation

devversion
Copy link
Member

Currently the errors are sometimes not printed if the prerendering test
target fails. We fix this by always re-throwing the error at top-level. This
also ensures that the process exits with a non-zero exit code.

@devversion
build: print error if prerender test fails
625ee93 
Currently the errors are sometimes not printed if the
prerendering test target fails. We fix this by always re-throwing the
error at top-level. This also ensures that the process exits with a
non-zero exit code.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Jan 16, 2020
@devversion devversion requested a review from jelbourn as a code owner January 16, 2020 14:26
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 16, 2020
jelbourn
jelbourn approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 16, 2020
@jelbourn jelbourn merged commit 9321d4c into angular:master Jan 16, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@devversion @yifange
build: print error if prerender test fails (angular#18190)
b645594 
Currently the errors are sometimes not printed if the
prerendering test target fails. We fix this by always re-throwing the
error at top-level. This also ensures that the process exits with a
non-zero exit code.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @jelbourn @googlebot