refactor(datepicker): set up date range picker classes #18292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
mmalerba
reviewed
Jan 29, 2020
Moves some things around to set up the date range picker. Includes: * Moves all of the datepicker logic into a base class so that it can be reused between the single and range selection. * Makes the input being passed into a datepicker generic so that we can strongly type `MatDatepicker` to `MatDatepickerInput` and `MatDateRangePicker` to `MatDateRangeInput`. * Sets up min, max and date filter validation for the date range picker. * Hooks up the date range picker to the date range input. * Makes it so that a generic datepicker can be passed to a datepicker toggle. * Adds a `DateFilterFn` type so we don't have to repeat the signature for the filter function everywhere. Note that while picking a date range somewhat works now, it's still a bit broken. The primary goal of these changes was to have all of components in place and wired up so that we can start working on the UI in follow-up PRs.
crisbeto
force-pushed
the
date-range-picker-base
branch
from
09a936b to
f071c88
Compare
mmalerba
added
pr: lgtm
action: merge
crisbeto
added a commit
that referenced
this pull request
Jan 29, 2020
Moves some things around to set up the date range picker. Includes: * Moves all of the datepicker logic into a base class so that it can be reused between the single and range selection. * Makes the input being passed into a datepicker generic so that we can strongly type `MatDatepicker` to `MatDatepickerInput` and `MatDateRangePicker` to `MatDateRangeInput`. * Sets up min, max and date filter validation for the date range picker. * Hooks up the date range picker to the date range input. * Makes it so that a generic datepicker can be passed to a datepicker toggle. * Adds a `DateFilterFn` type so we don't have to repeat the signature for the filter function everywhere. Note that while picking a date range somewhat works now, it's still a bit broken. The primary goal of these changes was to have all of components in place and wired up so that we can start working on the UI in follow-up PRs.
crisbeto
added a commit
that referenced
this pull request
Feb 5, 2020
Moves some things around to set up the date range picker. Includes: * Moves all of the datepicker logic into a base class so that it can be reused between the single and range selection. * Makes the input being passed into a datepicker generic so that we can strongly type `MatDatepicker` to `MatDatepickerInput` and `MatDateRangePicker` to `MatDateRangeInput`. * Sets up min, max and date filter validation for the date range picker. * Hooks up the date range picker to the date range input. * Makes it so that a generic datepicker can be passed to a datepicker toggle. * Adds a `DateFilterFn` type so we don't have to repeat the signature for the filter function everywhere. Note that while picking a date range somewhat works now, it's still a bit broken. The primary goal of these changes was to have all of components in place and wired up so that we can start working on the UI in follow-up PRs.
crisbeto
added a commit
that referenced
this pull request
Feb 17, 2020
Moves some things around to set up the date range picker. Includes: * Moves all of the datepicker logic into a base class so that it can be reused between the single and range selection. * Makes the input being passed into a datepicker generic so that we can strongly type `MatDatepicker` to `MatDatepickerInput` and `MatDateRangePicker` to `MatDateRangeInput`. * Sets up min, max and date filter validation for the date range picker. * Hooks up the date range picker to the date range input. * Makes it so that a generic datepicker can be passed to a datepicker toggle. * Adds a `DateFilterFn` type so we don't have to repeat the signature for the filter function everywhere. Note that while picking a date range somewhat works now, it's still a bit broken. The primary goal of these changes was to have all of components in place and wired up so that we can start working on the UI in follow-up PRs.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 17, 2020
Moves some things around to set up the date range picker. Includes: * Moves all of the datepicker logic into a base class so that it can be reused between the single and range selection. * Makes the input being passed into a datepicker generic so that we can strongly type `MatDatepicker` to `MatDatepickerInput` and `MatDateRangePicker` to `MatDateRangeInput`. * Sets up min, max and date filter validation for the date range picker. * Hooks up the date range picker to the date range input. * Makes it so that a generic datepicker can be passed to a datepicker toggle. * Adds a `DateFilterFn` type so we don't have to repeat the signature for the filter function everywhere. Note that while picking a date range somewhat works now, it's still a bit broken. The primary goal of these changes was to have all of components in place and wired up so that we can start working on the UI in follow-up PRs.
crisbeto
added a commit
that referenced
this pull request
Feb 26, 2020
Moves some things around to set up the date range picker. Includes: * Moves all of the datepicker logic into a base class so that it can be reused between the single and range selection. * Makes the input being passed into a datepicker generic so that we can strongly type `MatDatepicker` to `MatDatepickerInput` and `MatDateRangePicker` to `MatDateRangeInput`. * Sets up min, max and date filter validation for the date range picker. * Hooks up the date range picker to the date range input. * Makes it so that a generic datepicker can be passed to a datepicker toggle. * Adds a `DateFilterFn` type so we don't have to repeat the signature for the filter function everywhere. Note that while picking a date range somewhat works now, it's still a bit broken. The primary goal of these changes was to have all of components in place and wired up so that we can start working on the UI in follow-up PRs.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves some things around to set up the date range picker. Includes:
MatDatepickertoMatDatepickerInputandMatDateRangePickertoMatDateRangeInput.DateFilterFntype so we don't have to repeat the signature for the filter function everywhere.Note that while picking a date range somewhat works now, it's still a bit broken. The primary goal of these changes was to have all of components in place and wired up so that we can start working on the UI in follow-up PRs.