Skip to content

refactor: fix CI failures for 9.0.x branch #18300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2020
Merged

refactor: fix CI failures for 9.0.x branch #18300

merged 2 commits into from
Jan 27, 2020

Conversation

devversion
Copy link
Member

@devversion devversion commented Jan 27, 2020 •
edited
Loading

Fixes CI failures in the 9.0.x branch. This is necessary so that the snapshot builds are properly built for the upcoming v9 major release.

crisbeto and others added 2 commits January 27, 2020 18:34
@googlebot

This comment has been minimized.

Sign in to view
@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Jan 27, 2020
jelbourn
jelbourn approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion marked this pull request as ready for review January 27, 2020 18:00
@devversion
Copy link
Member Author

We renamed ivy_test in the past. It looks like somehow ivy_test is still a required job based on the Github project settings.

crisbeto
crisbeto approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 27, 2020
@ngbot

This comment has been minimized.

Sign in to view
@crisbeto
Copy link
Member

crisbeto commented Jan 27, 2020 •
edited
Loading

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jan 27, 2020
@jelbourn jelbourn merged commit c00bd49 into angular:9.0.x Jan 27, 2020
@Splaktar Splaktar mentioned this pull request Jan 27, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner

@mmalerba mmalerba Awaiting requested review from mmalerba mmalerba is a code owner

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @googlebot @crisbeto @jelbourn