Skip to content

chore: edits for professionalism of our comments #18346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2020
Merged

chore: edits for professionalism of our comments #18346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cdk/a11y/interactivity-checker/interactivity-checker.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ describe('InteractivityChecker', () => {

appendElements([objectEl]);

// This is a hack to create an empty contentDocument for the frame element.
// This creates an empty contentDocument for the frame element.
objectEl.type = 'text/html';
objectEl.contentDocument!.body.appendChild(button);

Expand Down
6 changes: 3 additions & 3 deletions src/material/datepicker/datepicker-content.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ $mat-datepicker-touch-max-height: 788px;

.mat-datepicker-content-touch {
display: block;
// make sure the dialog scrolls rather than being cropped on ludicrously small screens
// Make sure the dialog scrolls rather than being cropped on ludicrously small screens
max-height: 80vh;
overflow: auto;

// TODO(mmalerba): hack to offset the padding of the dialog. Can be removed when we switch away
// from using dialog.
// Offsets the padding of the dialog.
// TODO(mmalerba): Remove when we switch away from using dialog.
margin: -24px;

.mat-calendar {
Expand Down
2 changes: 1 addition & 1 deletion src/material/form-field/form-field-outline.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ $mat-form-field-outline-subscript-padding:
}

.mat-form-field-outline-gap {
// hack for Chrome's treatment of borders with non-integer (scaled) widths
// Workaround for Chrome's treatment of borders with non-integer (scaled) widths
// refer to https://github.com/angular/components/issues/10710
border-radius: 0.000001px;

Expand Down
4 changes: 2 additions & 2 deletions src/material/form-field/form-field.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,8 @@ export class MatFormField extends _MatFormFieldMixinBase
@ContentChild(MatFormFieldControl) _controlNonStatic: MatFormFieldControl<any>;
@ContentChild(MatFormFieldControl, {static: true}) _controlStatic: MatFormFieldControl<any>;
get _control() {
// TODO(crisbeto): we need this hacky workaround in order to support both Ivy
// and ViewEngine. We should clean this up once Ivy is the default renderer.
// TODO(crisbeto): we need this workaround in order to support both Ivy and ViewEngine.
// We should clean this up once Ivy is the default renderer.
return this._explicitFormFieldControl || this._controlNonStatic || this._controlStatic;
}
set _control(value) {
Expand Down