-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Maps update #18358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maps update #18358
Conversation
Add MapPolygon component to Google Maps, allowing polygons to be added to a Google Map.
Add rectangle component to @angular/google-maps that allows rectangles to be overlayed over the Google map.
Add MapPolygon component to Google Maps, allowing polygons to be added to a Google Map.
Add rectangle component to @angular/google-maps that allows rectangles to be overlayed over the Google map.
Add NgZone fix to new components, map-rectangle and map-polygon.
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
I think you probably want to rebase your branch on top of master rather than bringing in all the commits |
Discussed offline. That is what I did here, it adds a bunch of commits because google-maps-next is a bit behind master. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
All of these commits are already in master except for by new google-maps related commits. I wrote those, and I accepted the cla. |
3d68736
to
72321c8
Compare
Closing in favor of #18485 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Moves recent changes from master into google-maps-next, so that new components can be altered to use the NgZone fix from pull request 18034