Skip to content

Maps update #18358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Maps update #18358

wants to merge 6 commits into from

Conversation

mbehrlich
Copy link
Collaborator

@mbehrlich mbehrlich commented Jan 31, 2020

Moves recent changes from master into google-maps-next, so that new components can be altered to use the NgZone fix from pull request 18034

Add MapPolygon component to Google Maps, allowing polygons to be added
to a Google Map.
Add rectangle component to @angular/google-maps that allows rectangles
to be overlayed over the Google map.
Add MapPolygon component to Google Maps, allowing polygons to be added
to a Google Map.
Add rectangle component to @angular/google-maps that allows rectangles
to be overlayed over the Google map.
Add NgZone fix to new components, map-rectangle and map-polygon.
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Jan 31, 2020
@jelbourn
Copy link
Member

I think you probably want to rebase your branch on top of master rather than bringing in all the commits

@mbehrlich
Copy link
Collaborator Author

I think you probably want to rebase your branch on top of master rather than bringing in all the commits

Discussed offline. That is what I did here, it adds a bunch of commits because google-maps-next is a bit behind master.

@mbehrlich mbehrlich added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Feb 1, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@mbehrlich
Copy link
Collaborator Author

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

Googlers: Go here for more info.

All of these commits are already in master except for by new google-maps related commits. I wrote those, and I accepted the cla.

@jelbourn
Copy link
Member

Closing in favor of #18485

@jelbourn jelbourn closed this Feb 13, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants