Skip to content

build: remove test blocklist #18372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions test/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@ ts_library(
name = "angular_test_init",
testonly = True,
# This file *must* end with "spec" in order for "karma_web_test_suite" to load it.
srcs = [
"angular-test-init-spec.ts",
"test-blocklist.ts",
],
srcs = ["angular-test-init-spec.ts"],
deps = [
"@npm//@angular/core",
"@npm//@angular/platform-browser-dynamic",
Expand Down
14 changes: 0 additions & 14 deletions test/angular-test-init-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import {
BrowserDynamicTestingModule,
platformBrowserDynamicTesting,
} from '@angular/platform-browser-dynamic/testing';
import {testBlocklist} from './test-blocklist';

/*
* Common setup / initialization for all unit tests in Angular Material and CDK.
Expand Down Expand Up @@ -55,16 +54,3 @@ function patchTestBedToDestroyFixturesAfterEveryTest(testBedInstance: TestBed) {
// https://github.com/angular/angular/blob/master/packages/core/testing/src/before_each.ts#L25
afterEach(() => testBedInstance.resetTestingModule());
}


// Filter out any tests explicitly given in the blocklist. The blocklist is empty in the
// components repository, but the file will be overwritten if the framework repository runs
// the Angular component test suites against the latest snapshots. This is helpful because
// sometimes breaking changes that break individual tests land in the framework repository.
// It should be possible to disable these tests until the component repository migrated the
// broken tests once the breaking change is released.
(jasmine.getEnv() as any).configure({
specFilter: function(spec: jasmine.Spec) {
return !testBlocklist || !testBlocklist[spec.getFullName()];
}
});
17 changes: 0 additions & 17 deletions test/test-blocklist.ts

This file was deleted.