Skip to content

fix(google-maps): avoid errors when accessing API too early #18376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2020
Merged

fix(google-maps): avoid errors when accessing API too early #18376

merged 1 commit into from
Feb 20, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 3, 2020

Fixes a bunch of errors that are thrown if we access the Google Maps-dependent methods before the API has loaded. We had everything typed correctly, but in all cases we were overriding the null checks.

@crisbeto
fix(google-maps): avoid errors when accessing API too early
063fef3 
Fixes a bunch of errors that are thrown if we access the Google Maps-dependent methods before the API has loaded. We had everything typed correctly, but in all cases we were overriding the null checks.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Feb 3, 2020
@crisbeto crisbeto requested a review from a team as a code owner February 3, 2020 21:51
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 3, 2020
jelbourn
jelbourn approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 3, 2020
@andrewseguin andrewseguin merged commit 591ac9c into angular:master Feb 20, 2020
@andrewseguin andrewseguin added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Feb 20, 2020
@snyk-bot snyk-bot mentioned this pull request Mar 11, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @jelbourn @devversion @googlebot @andrewseguin