Skip to content

feat(material-experimental/mdc-form-field): add support for accent and warn theming #18399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

devversion
Copy link
Member

Previously, we wired up the feature targeting in the theme, but the
additional styling for .mat-accent and .mat-warn were missing.

This commit adds styling for the accent and warn palettes. This also
fixes an issue where the line-ripple is not displayed.

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Feb 5, 2020
@devversion devversion requested a review from mmalerba as a code owner February 5, 2020 14:53
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 5, 2020
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 5, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…d warn palettes

Previously, we wired up the feature targeting in the theme, but the
additional styling for `.mat-accent` and `.mat-warn` were missing.

This commit adds styling for the accent and warn palettes. This also
fixes an issue where the line-ripple is not displayed.
@mmalerba mmalerba force-pushed the fix/mdc-form-field-theming branch from 937e382 to 2c8b6d7 Compare February 7, 2020 21:27
@mmalerba mmalerba merged commit b24b9e3 into angular:master Feb 7, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants