Skip to content

chore: fix detach typos in overlay and portal #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/lib/core/overlay/overlay-ref.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ export class OverlayRef implements PortalHost {
}

detach(): Promise<any> {
this._detatchBackdrop();
this._detachBackdrop();
return this._portalHost.detach();
}

dispose(): void {
this._detatchBackdrop();
this._detachBackdrop();
this._portalHost.dispose();
}

Expand Down Expand Up @@ -97,7 +97,7 @@ export class OverlayRef implements PortalHost {
}

/** Detaches the backdrop (if any) associated with the overlay. */
private _detatchBackdrop(): void {
private _detachBackdrop(): void {
let backdropToDetach = this._backdropElement;

if (backdropToDetach) {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/core/portal/portal-directives.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export class PortalHostDirective extends BasePortalHost implements OnDestroy {
return new Map<string, any>();
}

/** Detatches the currently attached Portal (if there is one) and attaches the given Portal. */
/** Detaches the currently attached Portal (if there is one) and attaches the given Portal. */
private _replaceAttachedPortal(p: Portal<any>): void {
if (this.hasAttached()) {
this.detach();
Expand Down
2 changes: 1 addition & 1 deletion src/lib/core/portal/portal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export abstract class Portal<T> {

/**
* Sets the PortalHost reference without performing `attach()`. This is used directly by
* the PortalHost when it is performing an `attach()` or `detatch()`.
* the PortalHost when it is performing an `attach()` or `detach()`.
*/
setAttachedHost(host: PortalHost) {
this._attachedHost = host;
Expand Down