refactor(dialog): remove custom injector usage #18565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the usage of our custom `PortalInjector` with Angular's `Injector`. The advantage of using the default one is that the injection logic is consistent with everything else and we don't have to require users to polyfill `WeakMap`. The idea here is to eventually replace all usages of `PortalInjector` with `Injector` and to deprecate it, but I wanted to try it out against `dialog` since it's probably the most used and well tested of the components that are using the custom injector.
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
Mar 3, 2020
Replaces the usage of our custom `PortalInjector` with Angular's `Injector`. The advantage of using the default one is that the injection logic is consistent with everything else and we don't have to require users to polyfill `WeakMap`. The idea here is to eventually replace all usages of `PortalInjector` with `Injector` and to deprecate it, but I wanted to try it out against `dialog` since it's probably the most used and well tested of the components that are using the custom injector. (cherry picked from commit ff8d56e)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the usage of our custom
PortalInjectorwith Angular'sInjector. The advantage of using the default one is that the injection logic is consistent with everything else and we don't have to require users to polyfillWeakMap.The idea here is to eventually replace all usages of
PortalInjectorwithInjectorand to deprecate it, but I wanted to try it out againstdialogsince it's probably the most used and well tested of the components that are using the custom injector.