Skip to content

Maps circle #18568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2020
Merged

Maps circle #18568

merged 2 commits into from
Mar 12, 2020

Conversation

mbehrlich
Copy link
Collaborator

@mbehrlich mbehrlich commented Feb 20, 2020 •
edited
Loading

Add Circle component to Google Maps

@mbehrlich
feat(google-maps): Add Circle component
39e69c9 
Adds a component to draw a circle onto a Google Map.
@mbehrlich
feat(google-maps): Add Circle component
e43b6d1 
Update public API for circle component.
@mbehrlich mbehrlich requested a review from a team as a code owner February 20, 2020 23:17
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 20, 2020
@mbehrlich mbehrlich added feature This issue represents a new feature or feature request rather than a bug or bug fix google-maps P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Feb 21, 2020
@salorium
Copy link

salorium commented Mar 9, 2020

Hello,
do you have anything new about blocking?

jelbourn
jelbourn reviewed Mar 9, 2020
View reviewed changes
jelbourn
jelbourn approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, LGTM

@jelbourn jelbourn added merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed lgtm action: merge The PR is ready for merge by the caretaker labels Mar 9, 2020
@andrewseguin andrewseguin merged commit 3854db0 into angular:master Mar 12, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement feature This issue represents a new feature or feature request rather than a bug or bug fix merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mbehrlich @salorium @jelbourn @googlebot @mmalerba @andrewseguin