fix(material-experimental/mdc-radio): use consistent ripple timings #18590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
crisbeto
commented
Feb 23, 2020
crisbeto
commented
- Switches the MDC-based radio button to use the ripple timings from MDC, rather than a hardcoded one.
- Reworks the rest of the MDC-based components so that they don't re-create the ripple config object for each instance. It's not a huge improvement, there's no need for it to consume extra memory.
crisbeto
added
P3
googlebot
added
the
cla: yes
- Switches the MDC-based radio button to use the ripple timings from MDC, rather than a hardcoded one. - Reworks the rest of the MDC-based components so that they don't re-create the ripple config object for each instance. It's not a huge improvement, there's no need for it to consume extra memory.
crisbeto
force-pushed
the
mdc-radio-ripple-timings
branch
from
e6b9ce3 to
0cc94f1
Compare
devversion
approved these changes
Feb 26, 2020
jelbourn
pushed a commit
that referenced
this pull request
Mar 3, 2020
…18590) - Switches the MDC-based radio button to use the ripple timings from MDC, rather than a hardcoded one. - Reworks the rest of the MDC-based components so that they don't re-create the ripple config object for each instance. It's not a huge improvement, there's no need for it to consume extra memory. (cherry picked from commit 76846b8)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.