docs(form-field): use value getter when returning form data #18609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
approved these changes
Feb 25, 2020
devversion
added
the
merge: fix commit message
jelbourn
changed the title
mmalerba
added
pr: lgtm
action: merge
|
@mmalerba @devversion Thanks for looking at this. I am not sure what's still needed for this PR to merged. |
|
@tobiasschweizer Thanks for the PR. No action is needed from your side. The PR will be merged soon. |
devversion
added
the
target: patch
jelbourn
pushed a commit
that referenced
this pull request
Mar 3, 2020
(cherry picked from commit 33f977c)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an inconsistency in the example for creating a custom form field control.
Now when writing to and updating the value from the custom form field control, the value's setter and getter are used. Instead of a mere object, the component interacting with the custom form field control now deals with an instance of
MyTel.resolves #18537