perf(focus-monitor): avoid triggering unnecessary change detections #18668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mleibman
requested review from
andrewseguin,
devversion and
jelbourn
as code owners
googlebot
added
the
cla: yes
mmalerba
requested changes
Mar 2, 2020
src/components-examples/cdk/a11y/focus-monitor-directives/focus-monitor-directives-example.html
Outdated
Show resolved
Hide resolved
src/components-examples/cdk/a11y/focus-monitor-directives/focus-monitor-directives-example.html
Outdated
Show resolved
Hide resolved
jelbourn
added
the
P2
andrewseguin
added
needs rebase
and removed
action: merge
|
Please rebase, thanks! |
mmalerba
added
action: merge
mmalerba
force-pushed
the
perf-focusmonitor-ngzone
branch
2 times, most recently
from
734d08a to
20a56c9
Compare
mmalerba
force-pushed
the
perf-focusmonitor-ngzone
branch
from
20a56c9 to
eaa12a0
Compare
|
Needs rebase (sorry, this is taking a while due to failures internally) |
zarend
added
the
presubmit failures
andrewseguin
removed
the
cla: yes
josephperrott
added
action: cleanup
|
This was addressed in #15077. Closing. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #15077, but IMHO does it in much simpler way.
I also fixed up the documentation, examples, and some call sites that incorrectly stated that
FocusMonitoremits the observable outside ofNgZone.Caretaker note: #15077 had to be reverted before (#15076) because there was an app that depended on the extra change detections. We may have to investigate further before we can merge this in again.