build: fix dev-server running in snippet mode #18679
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsersync has 3 possible modes.
snippet
,proxy
andserver
. Wecurrently run with
snippet
even though we actually want to serve withthe live-reloading script being injected automatically.
In order to ensure that Browsersync runs in the
server
mode andproperly prints the URL to the http server, we re-enable the
server
option that has been disabled in the past for security reasons.The logic to prevent directory traversal still remains, and we also
explicitly disable directory listing (even though we have manual request
interception).
@jelbourn I verified that your directory traversal logic still works: