fix(drag-drop): detect changes on custom preview/placeholder before measuring #18698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…easuring When a custom preview/placeholder is created, its dimensions are measured so that they can be used while sorting. The problem is that we weren't detecting changes after creation which can cause the dimensions to be incorrect, if they change based on a data binding. These changes check for changes after inserting the embedded view. Fixes angular#18622.
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
reviewed
Mar 3, 2020
| @@ -884,6 +884,7 @@ export class DragRef<T = any> { | |||
| if (previewTemplate) { | |||
| const viewRef = previewConfig!.viewContainer.createEmbeddedView(previewTemplate, | |||
| previewConfig!.context); | |||
| viewRef.detectChanges(); | |||
There was a problem hiding this comment.
Rather than directly calling detectChanges, couldn't we instead defer measuring until Angular completes the change detection it needs to do anyway?
There was a problem hiding this comment.
Almost none of the drag&drop events trigger change detection so we can't really depend on it since it can happen at any time for other reason. This only detects on a small chunk of the tree anyway.
andrewseguin
pushed a commit
that referenced
this pull request
Mar 12, 2020
…easuring (#18698) When a custom preview/placeholder is created, its dimensions are measured so that they can be used while sorting. The problem is that we weren't detecting changes after creation which can cause the dimensions to be incorrect, if they change based on a data binding. These changes check for changes after inserting the embedded view. Fixes #18622. (cherry picked from commit e87de13)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a custom preview/placeholder is created, its dimensions are measured so that they can be used while sorting. The problem is that we weren't detecting changes after creation which can cause the dimensions to be incorrect, if they change based on a data binding. These changes check for changes after inserting the embedded view.
Fixes #18622.