refactor: ensure typography mixins expect consistent arguments #18738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have a few components with typography mixins that do not match the majority of other components. These components have typography mixins where the `$config` is optional. We want to always require a config (similar to how it's done in other components) to avoid breaking changes in the future, and to have a consistent API.
devversion
added
merge safe
target: patch
googlebot
added
the
cla: yes
|
I think the idea was that not passing a config would default to using MDC's typography settings. Since we're now working on a separate plan for migrating Angular Material to use MDC's config format this change is probably ok |
mmalerba
approved these changes
Mar 6, 2020
mmalerba
pushed a commit
that referenced
this pull request
Mar 6, 2020
Currently we have a few components with typography mixins that do not match the majority of other components. These components have typography mixins where the `$config` is optional. We want to always require a config (similar to how it's done in other components) to avoid breaking changes in the future, and to have a consistent API.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a few components with typography mixins that do
not match the majority of other components. These components have
typography mixins where the
$configis optional. We want to alwaysrequire a config (similar to how it's done in other components) to avoid
breaking changes in the future, and to have a consistent API.