fix(mdc-form-field): refresh notch width when toggling appearances #18776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oggling appearances Previously, switching between outline and filled appearance caused the notch width to be incorrect in some situations. This is because then notched-outline component does not sync with the underlying MDC component in case width and open state have been set upon `ngOnInit`.
…rea overrides selector
devversion
added
merge safe
target: patch
googlebot
added
the
cla: yes
andrewseguin
pushed a commit
that referenced
this pull request
Mar 12, 2020
…18776) * fix(material-experimental/mdc-form-field): refresh notch width when toggling appearances Previously, switching between outline and filled appearance caused the notch width to be incorrect in some situations. This is because then notched-outline component does not sync with the underlying MDC component in case width and open state have been set upon `ngOnInit`. * refactor(material/material-experimental): reduce specificity of textarea overrides selector (cherry picked from commit 76c3fb6)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, switching between outline and filled appearance caused the notch width to be
incorrect in some situations. This is because then notched-outline component does not sync
with the underlying MDC component in case width and open state have been set upon
ngOnInit.I'm thinking whether we should add tests for this wrapper component of MDC, but at the same time it feels unnecessary since it's a thin wrapper and mostly we'd need to assert MDC specifics.