Skip to content

refactor(material-experimental/mdc-chips): implement trailing icon foundation #18877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

crisbeto
Copy link
Member

The new foundation isn't being used yet, but these changes implement it so it's easier to roll out in the future.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 20, 2020
@crisbeto crisbeto force-pushed the mdc-trailing-icon-foundation branch 2 times, most recently from fb95b1c to d2d990d Compare March 20, 2020 22:12
@crisbeto crisbeto marked this pull request as ready for review March 20, 2020 22:25
@crisbeto crisbeto requested review from jelbourn, mmalerba and a team as code owners March 20, 2020 22:25
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Mar 20, 2020
@crisbeto crisbeto force-pushed the mdc-trailing-icon-foundation branch from d2d990d to 3fbe972 Compare April 3, 2020 19:48
@crisbeto
Copy link
Member Author

crisbeto commented Apr 3, 2020

I've addressed the feedback.

…undation

The new foundation isn't being used yet, but these changes implement it so it's easier to roll out in the future.
@crisbeto crisbeto force-pushed the mdc-trailing-icon-foundation branch from 3fbe972 to d0d34d9 Compare April 11, 2020 11:14
mmalerba pushed a commit that referenced this pull request May 11, 2020
…undation

Project import generated by Copybara.

These changes are mostly based on @crisbeto's #18877 with some
additional changes from @ProDee

PiperOrigin-RevId: 310167103

Co-authored-by: crisbeto <[email protected]>
Co-authored-by: prodee <[email protected]>
@crisbeto
Copy link
Member Author

Closing in favor of #19318.

@crisbeto crisbeto closed this May 12, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants