refactor(material-experimental/mdc-form-field): unset MDC custom baseline adjustment #18892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…line adjustment Recently with b2e8691, we updated to the latest canary version of the MDC text-field. MDC updated how they align the input vertically. We decided to still use our custom alignment using padding that will also work for custom form field controls. Since we still use padding alignment, we can unset the MDC custom baseline styles. These currently have no effect, but will cause the form-field to always have a minimum height that needs extra treatment for the density levels.
googlebot
added
the
cla: yes
devversion
added
merge safe
target: patch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently with b2e8691, we updated to the latest canary version
of the MDC text-field. MDC updated how they align the input vertically.
We decided to still use our custom alignment using padding that will
also work for custom form field controls.
Since we still use padding alignment, we can unset the MDC
custom baseline styles. These currently have no effect, but
will cause the form-field to always have a minimum height that
needs extra treatment for the density levels.
Note: I will send an upstream PR on
material-components-web. We should have more flexibility (individual mixins) for parts of the form-field. That should reduce unnecessary styles, and we should also not need any overrides.