Skip to content

refactor(tree): remove renderer usage #18930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2020
Merged

refactor(tree): remove renderer usage #18930

merged 1 commit into from
Mar 31, 2020

Conversation

crisbeto
Copy link
Member

We've mostly gotten rid of the Renderer2 usages in favor of native APIs, but this is one of the few places left where we were still using it.

@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Mar 26, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 26, 2020
@crisbeto
refactor(tree): remove renderer usage
5624e4a 
We've mostly gotten rid of the `Renderer2` usages in favor of native APIs, but this is one of the few places left where we were still using it.
@crisbeto crisbeto force-pushed the tree-renderer-remove branch from 013d9a8 to 5624e4a Compare March 26, 2020 22:35
jelbourn
jelbourn approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 30, 2020
@Achilles1515
Copy link

@crisbeto
Why are native APIs preferred over Renderer2? Just curious - as I remember reading articles like this when first learning Angular.

@jelbourn jelbourn merged commit 09d0b1f into angular:master Mar 31, 2020
jelbourn pushed a commit that referenced this pull request Apr 6, 2020
@crisbeto @jelbourn
refactor(tree): remove renderer usage (#18930)
8ab769d 
We've mostly gotten rid of the `Renderer2` usages in favor of native APIs, but this is one of the few places left where we were still using it.

(cherry picked from commit 09d0b1f)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @Achilles1515 @jelbourn @googlebot