Skip to content

fix(google-maps): update to latest typings and remove manual override #18990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 4, 2020

Bumps us to the latest version of the Google Maps typings and removes a workaround that was in place due to the old ones being incomplete.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Apr 4, 2020
@crisbeto crisbeto requested review from jelbourn and a team as code owners April 4, 2020 17:19
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 4, 2020
@crisbeto crisbeto force-pushed the google-maps-typings branch from df7b7b2 to dad5c3a Compare April 4, 2020 17:23
Bumps us to the latest version of the Google Maps typings and removes a workaround that was in place due to the old ones being incomplete.
@crisbeto crisbeto force-pushed the google-maps-typings branch from dad5c3a to ca71879 Compare April 4, 2020 17:32
@jelbourn jelbourn requested a review from mbehrlich April 23, 2020 21:57
@jelbourn
Copy link
Member

@crisbeto is this PR obsolete?

@mbehrlich
Copy link
Collaborator

@crisbeto is this PR obsolete?

This should all be taken care of now from my last PR.

@crisbeto
Copy link
Member Author

crisbeto commented Apr 24, 2020

Closing, but is there a way we can avoid stepping over each other like this in the future? When I opened the PR 20 days ago, I looked through all the open PRs and there weren't any that addressed this issue.

@crisbeto crisbeto closed this Apr 24, 2020
@mbehrlich
Copy link
Collaborator

Closing, but is there a way we can avoid stepping over each other like this in the future? When I opened the PR 20 days ago, I looked through all the open PRs and there weren't any that addressed this issue.

It was in this pull request, #18613. I thought you saw it actually, it was open at the time and you reviewed part of it. In the future, feel free to send me a message on slack and/or add me as a reviewer to google-maps related stuff. My next steps are going to be to implement some layer features: KML Layer, Traffic, transit and bicycle layers, etc.

@crisbeto
Copy link
Member Author

Ah sorry, I must've forgotten about that about that PR. I'll also make sure to look closer next time.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants