Skip to content

refactor: consistently re-export common module #19095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/material-experimental/mdc-chips/module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const CHIP_DECLARATIONS = [

@NgModule({
imports: [MatCommonModule, CommonModule, MatRippleModule],
exports: CHIP_DECLARATIONS,
exports: [MatCommonModule, CHIP_DECLARATIONS],
declarations: CHIP_DECLARATIONS,
providers: [
ErrorStateMatcher,
Expand Down
2 changes: 1 addition & 1 deletion src/material-experimental/mdc-menu/module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {MatMenuItem} from './menu-item';
OverlayModule,
_MatMenuDirectivesModule
],
exports: [MatMenu, MatMenuItem, _MatMenuDirectivesModule],
exports: [MatMenu, MatCommonModule, MatMenuItem, _MatMenuDirectivesModule],
declarations: [MatMenu, MatMenuItem],
providers: [MAT_MENU_SCROLL_STRATEGY_FACTORY_PROVIDER]
})
Expand Down
2 changes: 1 addition & 1 deletion src/material-experimental/mdc-radio/module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {MatRadioButton, MatRadioGroup} from './radio';

@NgModule({
imports: [MatCommonModule, CommonModule, MatRippleModule],
exports: [MatRadioGroup, MatRadioButton],
exports: [MatCommonModule, MatRadioGroup, MatRadioButton],
declarations: [MatRadioGroup, MatRadioButton],
})
export class MatRadioModule {
Expand Down
2 changes: 1 addition & 1 deletion src/material-experimental/mdc-table/module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const EXPORTED_DECLARATIONS = [

@NgModule({
imports: [MatCommonModule, CdkTableModule],
exports: EXPORTED_DECLARATIONS,
exports: [MatCommonModule, EXPORTED_DECLARATIONS],
declarations: EXPORTED_DECLARATIONS,
})
export class MatTableModule {
Expand Down
2 changes: 1 addition & 1 deletion src/material/badge/badge-module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {MatBadge} from './badge';
A11yModule,
MatCommonModule
],
exports: [MatBadge],
exports: [MatBadge, MatCommonModule],
declarations: [MatBadge],
})
export class MatBadgeModule {}
2 changes: 1 addition & 1 deletion src/material/menu/menu-module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export class _MatMenuDirectivesModule {}
OverlayModule,
_MatMenuDirectivesModule,
],
exports: [_MatMenu, MatMenuItem, _MatMenuDirectivesModule],
exports: [MatCommonModule, _MatMenu, MatMenuItem, _MatMenuDirectivesModule],
declarations: [_MatMenu, MatMenuItem],
providers: [MAT_MENU_SCROLL_STRATEGY_FACTORY_PROVIDER]
})
Expand Down
2 changes: 1 addition & 1 deletion src/material/table/table-module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const EXPORTED_DECLARATIONS = [
CdkTableModule,
MatCommonModule,
],
exports: EXPORTED_DECLARATIONS,
exports: [MatCommonModule, EXPORTED_DECLARATIONS],
declarations: EXPORTED_DECLARATIONS,
})
export class MatTableModule {}
2 changes: 1 addition & 1 deletion src/material/tree/tree-module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const MAT_TREE_DIRECTIVES = [

@NgModule({
imports: [CdkTreeModule, MatCommonModule],
exports: MAT_TREE_DIRECTIVES,
exports: [MatCommonModule, MAT_TREE_DIRECTIVES],
declarations: MAT_TREE_DIRECTIVES,
})
export class MatTreeModule {}
2 changes: 1 addition & 1 deletion tools/public_api_guard/material/badge.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export declare class MatBadge extends _MatBadgeMixinBase implements OnDestroy, O

export declare class MatBadgeModule {
static ɵinj: i0.ɵɵInjectorDef<MatBadgeModule>;
static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatBadgeModule, [typeof i1.MatBadge], [typeof i2.A11yModule, typeof i3.MatCommonModule], [typeof i1.MatBadge]>;
static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatBadgeModule, [typeof i1.MatBadge], [typeof i2.A11yModule, typeof i3.MatCommonModule], [typeof i1.MatBadge, typeof i3.MatCommonModule]>;
}

export declare type MatBadgePosition = 'above after' | 'above before' | 'below before' | 'below after' | 'before' | 'after' | 'above' | 'below';
Expand Down
2 changes: 1 addition & 1 deletion tools/public_api_guard/material/menu.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export declare class MatMenuItem extends _MatMenuItemMixinBase implements Focusa

export declare class MatMenuModule {
static ɵinj: i0.ɵɵInjectorDef<MatMenuModule>;
static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatMenuModule, [typeof i4._MatMenu, typeof i5.MatMenuItem], [typeof i6.CommonModule, typeof i3.MatCommonModule, typeof i3.MatRippleModule, typeof i7.OverlayModule, typeof _MatMenuDirectivesModule], [typeof i4._MatMenu, typeof i5.MatMenuItem, typeof _MatMenuDirectivesModule]>;
static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatMenuModule, [typeof i4._MatMenu, typeof i5.MatMenuItem], [typeof i6.CommonModule, typeof i3.MatCommonModule, typeof i3.MatRippleModule, typeof i7.OverlayModule, typeof _MatMenuDirectivesModule], [typeof i3.MatCommonModule, typeof i4._MatMenu, typeof i5.MatMenuItem, typeof _MatMenuDirectivesModule]>;
}

export interface MatMenuPanel<T = any> {
Expand Down
2 changes: 1 addition & 1 deletion tools/public_api_guard/material/table.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export declare class MatTableDataSource<T> extends DataSource<T> {

export declare class MatTableModule {
static ɵinj: i0.ɵɵInjectorDef<MatTableModule>;
static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatTableModule, [typeof i1.MatTable, typeof i2.MatHeaderCellDef, typeof i3.MatHeaderRowDef, typeof i2.MatColumnDef, typeof i2.MatCellDef, typeof i3.MatRowDef, typeof i2.MatFooterCellDef, typeof i3.MatFooterRowDef, typeof i2.MatHeaderCell, typeof i2.MatCell, typeof i2.MatFooterCell, typeof i3.MatHeaderRow, typeof i3.MatRow, typeof i3.MatFooterRow, typeof i4.MatTextColumn], [typeof i5.CdkTableModule, typeof i6.MatCommonModule], [typeof i1.MatTable, typeof i2.MatHeaderCellDef, typeof i3.MatHeaderRowDef, typeof i2.MatColumnDef, typeof i2.MatCellDef, typeof i3.MatRowDef, typeof i2.MatFooterCellDef, typeof i3.MatFooterRowDef, typeof i2.MatHeaderCell, typeof i2.MatCell, typeof i2.MatFooterCell, typeof i3.MatHeaderRow, typeof i3.MatRow, typeof i3.MatFooterRow, typeof i4.MatTextColumn]>;
static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatTableModule, [typeof i1.MatTable, typeof i2.MatHeaderCellDef, typeof i3.MatHeaderRowDef, typeof i2.MatColumnDef, typeof i2.MatCellDef, typeof i3.MatRowDef, typeof i2.MatFooterCellDef, typeof i3.MatFooterRowDef, typeof i2.MatHeaderCell, typeof i2.MatCell, typeof i2.MatFooterCell, typeof i3.MatHeaderRow, typeof i3.MatRow, typeof i3.MatFooterRow, typeof i4.MatTextColumn], [typeof i5.CdkTableModule, typeof i6.MatCommonModule], [typeof i6.MatCommonModule, typeof i1.MatTable, typeof i2.MatHeaderCellDef, typeof i3.MatHeaderRowDef, typeof i2.MatColumnDef, typeof i2.MatCellDef, typeof i3.MatRowDef, typeof i2.MatFooterCellDef, typeof i3.MatFooterRowDef, typeof i2.MatHeaderCell, typeof i2.MatCell, typeof i2.MatFooterCell, typeof i3.MatHeaderRow, typeof i3.MatRow, typeof i3.MatFooterRow, typeof i4.MatTextColumn]>;
}

export declare class MatTextColumn<T> extends CdkTextColumn<T> {
Expand Down
2 changes: 1 addition & 1 deletion tools/public_api_guard/material/tree.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export declare class MatTreeFlattener<T, F> {

export declare class MatTreeModule {
static ɵinj: i0.ɵɵInjectorDef<MatTreeModule>;
static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatTreeModule, [typeof i1.MatNestedTreeNode, typeof i1.MatTreeNodeDef, typeof i2.MatTreeNodePadding, typeof i3.MatTreeNodeToggle, typeof i4.MatTree, typeof i1.MatTreeNode, typeof i5.MatTreeNodeOutlet], [typeof i6.CdkTreeModule, typeof i7.MatCommonModule], [typeof i1.MatNestedTreeNode, typeof i1.MatTreeNodeDef, typeof i2.MatTreeNodePadding, typeof i3.MatTreeNodeToggle, typeof i4.MatTree, typeof i1.MatTreeNode, typeof i5.MatTreeNodeOutlet]>;
static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatTreeModule, [typeof i1.MatNestedTreeNode, typeof i1.MatTreeNodeDef, typeof i2.MatTreeNodePadding, typeof i3.MatTreeNodeToggle, typeof i4.MatTree, typeof i1.MatTreeNode, typeof i5.MatTreeNodeOutlet], [typeof i6.CdkTreeModule, typeof i7.MatCommonModule], [typeof i7.MatCommonModule, typeof i1.MatNestedTreeNode, typeof i1.MatTreeNodeDef, typeof i2.MatTreeNodePadding, typeof i3.MatTreeNodeToggle, typeof i4.MatTree, typeof i1.MatTreeNode, typeof i5.MatTreeNodeOutlet]>;
}

export declare class MatTreeNestedDataSource<T> extends DataSource<T> {
Expand Down