Skip to content

fix(material-experimental/form-field): add filled MDC text field class #19103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2020
Merged

fix(material-experimental/form-field): add filled MDC text field class #19103

merged 1 commit into from
Apr 20, 2020

Conversation

asyncLiz
Copy link
Contributor

This should fix continuous build errors caused by cl/306969414. MDC recently refactored textfield to add the mdc-text-field--filled class for more explicit default styles. A breaking change is that non-outlined text fields must specify this class.

@asyncLiz asyncLiz requested review from devversion, jelbourn, mmalerba and a team as code owners April 18, 2020 05:56
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 18, 2020
@devversion devversion self-assigned this Apr 18, 2020
crisbeto
crisbeto approved these changes Apr 18, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added lgtm action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Apr 18, 2020
devversion
devversion approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (tested manually too).

Not sure if fix is the right commit type here since we are just updating a version and accounting for the new breaking change.

@jelbourn jelbourn merged commit 0bd1e4a into angular:master Apr 20, 2020
jelbourn pushed a commit that referenced this pull request Apr 20, 2020
@asyncLiz @jelbourn
fix(material-experimental/form-field): add filled MDC text field class (
54c5633 
#19103)

(cherry picked from commit 0bd1e4a)
soro-google pushed a commit to soro-google/components that referenced this pull request Apr 24, 2020
@asyncLiz @soro-google
fix(material-experimental/form-field): add filled MDC text field class (
7098b79 
angular#19103)
@snyk-bot snyk-bot mentioned this pull request May 3, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asyncLiz @crisbeto @devversion @jelbourn @googlebot