Skip to content

refactor: add missing abstract directive decorators #19256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2020
Merged

refactor: add missing abstract directive decorators #19256

merged 1 commit into from
May 6, 2020

Conversation

devversion
Copy link
Member

In version 10 of Angular, undecorated base classes using Angular
features (including the use of lifecycle hooks) are no longer supported.

Needed for angular/angular#36921

@devversion
refactor: add missing abstract directive decorators
0013e31 
In version 10 of Angular, undecorated base classes using
Angular features (including the use of lifecycle hooks)
are no longer supported.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 4, 2020
@devversion devversion marked this pull request as ready for review May 4, 2020 22:22
@devversion devversion requested review from andrewseguin, jelbourn, mmalerba and a team as code owners May 4, 2020 22:22
jelbourn
jelbourn approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 5, 2020
@devversion devversion added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent P2 The issue is important to a large percentage of users, with a workaround and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels May 5, 2020
Splaktar
Splaktar approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit 505db7b into angular:master May 6, 2020
andrewseguin pushed a commit that referenced this pull request May 6, 2020
@devversion @andrewseguin
refactor: add missing abstract directive decorators (#19256)
70ddc36 
In version 10 of Angular, undecorated base classes using
Angular features (including the use of lifecycle hooks)
are no longer supported.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@Splaktar Splaktar Splaktar approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devversion @jelbourn @Splaktar @googlebot @andrewseguin