Skip to content

build: update to typescript 3.9 #19286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2020
Merged

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 8, 2020

The Framework team is in the process of updating to TS 3.9 (see angular/angular#36989) which means that soon we'll have to switch to it as well. These changes update us to the latest RC and resolve all of the build issues so that we can quickly switch to the final version once it's available.

Note: I had to add some as any casts, because a few non-standard properties were removed from the CSSStyleDeclaration.

The Framework team is in the process of updating to TS 3.9 (see angular/angular#36989) which means that soon we'll have to switch to it as well. These changes update us to the latest RC and resolve all of the build issues so that we can quickly switch to the final version once it's available.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 8, 2020
@crisbeto crisbeto marked this pull request as ready for review May 8, 2020 09:19
@crisbeto crisbeto requested review from andrewseguin, devversion, jelbourn and a team as code owners May 8, 2020 09:19
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels May 8, 2020
@devversion devversion added the lgtm label May 8, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label May 8, 2020
@jelbourn jelbourn merged commit da13167 into angular:master May 8, 2020
devversion added a commit to devversion/material2 that referenced this pull request May 12, 2020
We recently updated TS 3.9 in the `package.json` with
angular#19286, but
the build did not pick up the new version. This is
because peer dependency ranges did not accept TS 3.9,
so yarn hoisted sufficient TS versions.
devversion added a commit to devversion/material2 that referenced this pull request May 12, 2020
We recently updated TS 3.9 in the `package.json` with
angular#19286, but
the build did not pick up the new version. This is
because peer dependency ranges did not accept TS 3.9,
so yarn hoisted sufficient TS versions.
devversion added a commit to devversion/material2 that referenced this pull request May 12, 2020
We recently updated TS 3.9 in the `package.json` with
angular#19286, but
the build did not pick up the new version. This is
because peer dependency ranges did not accept TS 3.9,
so yarn hoisted sufficient TS versions.
devversion added a commit to devversion/material2 that referenced this pull request May 13, 2020
We recently updated TS 3.9 in the `package.json` with
angular#19286, but
the build did not pick up the new version. This is
because peer dependency ranges did not accept TS 3.9,
so yarn hoisted sufficient TS versions.
devversion added a commit to devversion/material2 that referenced this pull request May 13, 2020
We recently updated TS 3.9 in the `package.json` with
angular#19286, but
the build did not pick up the new version. This is
because peer dependency ranges did not accept TS 3.9,
so yarn hoisted sufficient TS versions.
devversion added a commit to devversion/material2 that referenced this pull request May 13, 2020
We recently updated TS 3.9 in the `package.json` with
angular#19286, but
the build did not pick up the new version. This is
because peer dependency ranges did not accept TS 3.9,
so yarn hoisted sufficient TS versions.
devversion added a commit to devversion/material2 that referenced this pull request May 13, 2020
We recently updated TS 3.9 in the `package.json` with
angular#19286, but
the build did not pick up the new version. This is
because peer dependency ranges did not accept TS 3.9,
so yarn hoisted sufficient TS versions.
devversion added a commit to devversion/material2 that referenced this pull request May 13, 2020
We recently updated TS 3.9 in the `package.json` with
angular#19286, but
the build did not pick up the new version. This is
because peer dependency ranges did not accept TS 3.9,
so yarn hoisted sufficient TS versions.
devversion added a commit to devversion/material2 that referenced this pull request May 18, 2020
We recently updated TS 3.9 in the `package.json` with
angular#19286, but
the build did not pick up the new version. This is
because peer dependency ranges did not accept TS 3.9,
so yarn hoisted sufficient TS versions.
devversion added a commit to devversion/material2 that referenced this pull request May 18, 2020
We recently updated TS 3.9 in the `package.json` with
angular#19286, but
the build did not pick up the new version. This is
because peer dependency ranges did not accept TS 3.9,
so yarn hoisted sufficient TS versions.
mmalerba pushed a commit that referenced this pull request May 18, 2020
We recently updated TS 3.9 in the `package.json` with
#19286, but
the build did not pick up the new version. This is
because peer dependency ranges did not accept TS 3.9,
so yarn hoisted sufficient TS versions.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants