-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: update to typescript 3.9 #19286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Framework team is in the process of updating to TS 3.9 (see angular/angular#36989) which means that soon we'll have to switch to it as well. These changes update us to the latest RC and resolve all of the build issues so that we can quickly switch to the final version once it's available.
devversion
approved these changes
May 8, 2020
jelbourn
approved these changes
May 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
devversion
added a commit
to devversion/material2
that referenced
this pull request
May 12, 2020
We recently updated TS 3.9 in the `package.json` with angular#19286, but the build did not pick up the new version. This is because peer dependency ranges did not accept TS 3.9, so yarn hoisted sufficient TS versions.
devversion
added a commit
to devversion/material2
that referenced
this pull request
May 12, 2020
We recently updated TS 3.9 in the `package.json` with angular#19286, but the build did not pick up the new version. This is because peer dependency ranges did not accept TS 3.9, so yarn hoisted sufficient TS versions.
devversion
added a commit
to devversion/material2
that referenced
this pull request
May 12, 2020
We recently updated TS 3.9 in the `package.json` with angular#19286, but the build did not pick up the new version. This is because peer dependency ranges did not accept TS 3.9, so yarn hoisted sufficient TS versions.
devversion
added a commit
to devversion/material2
that referenced
this pull request
May 13, 2020
We recently updated TS 3.9 in the `package.json` with angular#19286, but the build did not pick up the new version. This is because peer dependency ranges did not accept TS 3.9, so yarn hoisted sufficient TS versions.
devversion
added a commit
to devversion/material2
that referenced
this pull request
May 13, 2020
We recently updated TS 3.9 in the `package.json` with angular#19286, but the build did not pick up the new version. This is because peer dependency ranges did not accept TS 3.9, so yarn hoisted sufficient TS versions.
devversion
added a commit
to devversion/material2
that referenced
this pull request
May 13, 2020
We recently updated TS 3.9 in the `package.json` with angular#19286, but the build did not pick up the new version. This is because peer dependency ranges did not accept TS 3.9, so yarn hoisted sufficient TS versions.
devversion
added a commit
to devversion/material2
that referenced
this pull request
May 13, 2020
We recently updated TS 3.9 in the `package.json` with angular#19286, but the build did not pick up the new version. This is because peer dependency ranges did not accept TS 3.9, so yarn hoisted sufficient TS versions.
devversion
added a commit
to devversion/material2
that referenced
this pull request
May 13, 2020
We recently updated TS 3.9 in the `package.json` with angular#19286, but the build did not pick up the new version. This is because peer dependency ranges did not accept TS 3.9, so yarn hoisted sufficient TS versions.
devversion
added a commit
to devversion/material2
that referenced
this pull request
May 18, 2020
We recently updated TS 3.9 in the `package.json` with angular#19286, but the build did not pick up the new version. This is because peer dependency ranges did not accept TS 3.9, so yarn hoisted sufficient TS versions.
devversion
added a commit
to devversion/material2
that referenced
this pull request
May 18, 2020
We recently updated TS 3.9 in the `package.json` with angular#19286, but the build did not pick up the new version. This is because peer dependency ranges did not accept TS 3.9, so yarn hoisted sufficient TS versions.
mmalerba
pushed a commit
that referenced
this pull request
May 18, 2020
We recently updated TS 3.9 in the `package.json` with #19286, but the build did not pick up the new version. This is because peer dependency ranges did not accept TS 3.9, so yarn hoisted sufficient TS versions.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
cla: yes
PR author has agreed to Google's Contributor License Agreement
P2
The issue is important to a large percentage of users, with a workaround
target: major
This PR is targeted for the next major release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Framework team is in the process of updating to TS 3.9 (see angular/angular#36989) which means that soon we'll have to switch to it as well. These changes update us to the latest RC and resolve all of the build issues so that we can quickly switch to the final version once it's available.
Note: I had to add some
as any
casts, because a few non-standard properties were removed from theCSSStyleDeclaration
.