fix: unable to set expanded or collapsed height in expansion panel #19322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the density system, we reworked the expansion panel to no longer rely on Angular animations. Looks like the refactoring missed that units are already set for the `expandedHeight` and `collapsedHeight` inputs. This hasn't been catched in any unit test, so tests are updated to catch this now.
googlebot
added
the
cla: yes
andrewseguin
added
lgtm
action: merge
devversion
added a commit
that referenced
this pull request
May 14, 2020
…19322) For the density system, we reworked the expansion panel to no longer rely on Angular animations. Looks like the refactoring missed that units are already set for the `expandedHeight` and `collapsedHeight` inputs. This hasn't been catched in any unit test, so tests are updated to catch this now.
devversion
added a commit
to devversion/material2
that referenced
this pull request
May 14, 2020
Note: This commit is intentionally not marked as a feature because density styles for the expansion panel are not public API yet: Adds support for density scaling to the Angular Material expansion panel. To be able to add support for density, the panel header animation had to be reworked to be CSS based. The existing inputs for setting collapsed/expanded height still work as expected, but will not respect density. * chore: fix buildifier formatting due to update fix: unable to set expanded or collapsed height in expansion panel (angular#19322) For the density system, we reworked the expansion panel to no longer rely on Angular animations. Looks like the refactoring missed that units are already set for the `expandedHeight` and `collapsedHeight` inputs. This hasn't been catched in any unit test, so tests are updated to catch this now.
andrewseguin
pushed a commit
that referenced
this pull request
May 14, 2020
Note: This commit is intentionally not marked as a feature because density styles for the expansion panel are not public API yet: Adds support for density scaling to the Angular Material expansion panel. To be able to add support for density, the panel header animation had to be reworked to be CSS based. The existing inputs for setting collapsed/expanded height still work as expected, but will not respect density. * chore: fix buildifier formatting due to update fix: unable to set expanded or collapsed height in expansion panel (#19322) For the density system, we reworked the expansion panel to no longer rely on Angular animations. Looks like the refactoring missed that units are already set for the `expandedHeight` and `collapsedHeight` inputs. This hasn't been catched in any unit test, so tests are updated to catch this now.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the density system, we reworked the expansion panel to no longer
rely on Angular animations. Looks like the refactoring missed that units
are already set for the
expandedHeightandcollapsedHeightinputs.This hasn't been catched in any unit test, so tests are updated to catch this now.