Skip to content

fix(google-maps): allow different anchor objects for info window #19378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2020

Conversation

crisbeto
Copy link
Member

Currently the info window is limited only to markers, but the API allows for any kind of MVCObject. These changes expand the type so that we can make it more flexible in the future.

cc @mbehrlich

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels May 16, 2020
@crisbeto crisbeto requested a review from a team as a code owner May 16, 2020 13:58
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 16, 2020
Currently the info window is limited only to markers, but the API allows for any kind of `MVCObject`. These changes expand the type so that we can make it more flexible in the future.
@crisbeto crisbeto force-pushed the info-window-anchor branch from 60532ef to 72ea7d7 Compare May 16, 2020 14:07
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels May 18, 2020
@jelbourn jelbourn merged commit d0ab041 into angular:master May 21, 2020
@ourabio
Copy link

ourabio commented May 26, 2020

Hello, is it possible to have a custom info window with data for each marker? I am using markers for each position of products and on the window I want to show some of the products data. The API allows to set content on the infoWindow reference by setting content for each marker, so I tried to set the content before I open it but on this component we can only getContent() there is no setContent() function. Thanks!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants