fix(drag-drop): error during device emulation on firefox #19396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
changed the title
The events that Firefox emits when it emulates a mobile device in the dev tools are incomplete which causes an error to be thrown at the end of a drag seequence. These changes add a bit of extra logic so everything doesn't break down. Fixes angular#19385.
crisbeto
force-pushed
the
19385/emulated-firefox-error
branch
from
9dfd5bb to
240cde9
Compare
jelbourn
pushed a commit
that referenced
this pull request
May 21, 2020
The events that Firefox emits when it emulates a mobile device in the dev tools are incomplete which causes an error to be thrown at the end of a drag seequence. These changes add a bit of extra logic so everything doesn't break down. Fixes #19385.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The events that Firefox emits when it emulates a mobile device in the dev tools are incomplete which causes an error to be thrown at the end of a drag seequence. These changes add a bit of extra logic so everything doesn't break down.
Fixes #19385.